Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential early exit with CLI #86

Closed
wants to merge 2 commits into from
Closed

Fix potential early exit with CLI #86

wants to merge 2 commits into from

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Jan 27, 2020

Closes #85

@mmstick mmstick requested review from a team January 27, 2020 21:16
@brs17
Copy link
Contributor

brs17 commented Jan 29, 2020

@7FFY could you please take a look at see if this issue persists with this added patch? I was able to test to make sure it doesn't seem to break anything but I was unable to replicate your issue to begin with. You can either build it from source or:

git clone https://github.com/pop-os/pop
./pop/scripts/apt add cli-fix
sudo apt update
sudo apt full-upgrade

@7FFY
Copy link

7FFY commented Jan 29, 2020

@brs17 Np, gonna do this tomorrow however

@7FFY
Copy link

7FFY commented Jan 31, 2020

Hi, so I tested the patched version but the issue persist :/

Copy link
Contributor

@brs17 brs17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@mmstick
Copy link
Member Author

mmstick commented Jan 31, 2020

Sadly, I haven't been able to replicate the issue, either. So this will take more digging for a potential cause.

@mmstick mmstick closed this Mar 4, 2020
@mmstick mmstick deleted the cli-fix branch March 4, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendered usb media not working using CLI version
4 participants