Add support for incrementing global and beatmap playcounts #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
reviewed
Nov 9, 2023
|
|
||
| AddBeatmap(); | ||
|
|
||
| Task.Run(() => |
There was a problem hiding this comment.
Is there a reason why this is running in a Task that doesn't seem to be awaited anywhere? It almost looks like this task could still be running even after this test is complete, is that not the case?
Fwiw, I believe xunit tests can be public async Task
There was a problem hiding this comment.
Yeah that's probably bad, will fix.
smoogipoo
approved these changes
Nov 9, 2023
smoogipoo
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers
osu_countsplaycount, as well as beatmap and beatmap set level playcounts. All implemented using the same logic that as web-10.personal reminder: consider backfilling these fields from solo_scores when deploying.