Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static ruleset classes rather than constructing on each usage #283

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 18, 2024

These are used a lot, so this is quite a large saving. Mainly just aiming to get GC time down.

These are used a *lot*, so this is quite a large saving. Mainly just
aiming to get GC time down.
@bdach bdach self-requested a review October 21, 2024 07:45
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe

@bdach bdach merged commit 857de9b into ppy:master Oct 21, 2024
3 checks passed
@peppy peppy deleted the reduce-ruleset-allocs branch November 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants