Unapply non-buffered performance optimisation #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this quite yet. It's quite a performance hit for certain user cases and I might find a better way. |
ProxySQL doesn't work great with this. If there's a pause (or sometimes even if there isn't) ie. waiting for replication to catch up, the connection may be dropped causing the reading to fail and abort the whole process. I'm PRing this separately because I may bring this back in the near future, depending on how things go. Right now we're bottlenecked on writes, not reads, so it's not a huge issue.
|
@smoogipoo this is good to go for now |
smoogipoo
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProxySQL doesn't work great with this. If there's a pause (or sometimes even if there isn't) ie. connection may be dropped causing the reading to fail and abort the whole process.
I'm PRing this separately because I may bring this back in the near future, depending on how things go. Right now we're bottlenecked on writes, not reads, so it's not a huge issue.
Already using on production run.