No smarts allowed

Easier to understand.
ppy · Jan 15, 2025 · ac1b77b · ac1b77b
1 parent adecc03
commit ac1b77b
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/app/Models/Multiplayer/Room.php b/app/Models/Multiplayer/Room.php
@@ -763,11 +763,7 @@ private function assertValidStartPlay(User $user, PlaylistItem $playlistItem, ar
 
         if ($playlistItem->freestyle) {
             // assert the beatmap_id is part of playlist item's beatmapset
-            $beatmapsetIdCount = Beatmap
-                ::whereKey([$playlistItem->beatmap_id, $params['beatmap_id']])
-                ->distinct('beatmapset_id')
-                ->count();
-            if ($beatmapsetIdCount !== 1) {
+            if ($playlistItem->beatmap->beatmapset_id !== Beatmap::find($params['beatmap_id'])?->getKey()) {
                 throw new InvariantException('Specified beatmap_id is not allowed');
             }
         }