-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE] Add People/Featured Artists
#12487
Open
The-Last-Cookie
wants to merge
7
commits into
ppy:master
Choose a base branch
from
The-Last-Cookie:de-featured-artists
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−0
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b308c87
[DE] Add People/Featured_artists
The-Last-Cookie 4e92d88
Fix link
The-Last-Cookie 81445de
Apply suggestions from code review
The-Last-Cookie b8b2d6f
Apply #12585
The-Last-Cookie fdf217d
Apply #12660
The-Last-Cookie 7c2c85a
Apply suggestions from code review
The-Last-Cookie 589168a
Apply suggestions from code review
The-Last-Cookie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Apply suggestions from code review
Co-authored-by: FreezyLemon <[email protected]>
commit 81445dee5d84233695174be8ae4b3262f45cd766
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sponsern
almost always expresses a financial backing (as in osu! being a sponsor for these artists) and is not a good choice here in my opinion. We could maybe usefeatured
as-is (there is some precedence for this in Music i.e. "X hat ein Feature in Y's neuem Album") or fall back to something likeempfohlen
. Or just use the entire termfeatured artists
as a name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a financial backing because osu! buys a license from the musicians if I understand correctly.
If you don't like the term, I will change it to empfohlen.