refactor: Switch to vite-prerender-plugin
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
force-pushed
the
refactor/switch-to-vite-prerender-plugin
branch
from
2f7a44b to
3e0bc9a
Compare
rschristian
commented
Jan 9, 2025
package.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| "dev:build": "vite build demo", | |||
| "dev:preview": "vite preview demo", | |||
| "build": "rimraf dist && tsc && tsc -p tsconfig.cjs.json && node tools/postbuild.mjs", | |||
| "test": "node --test test", | |||
| "test": "rimraf demo/node_modules && node --test", | |||
There was a problem hiding this comment.
We create a temp dir in node_modules (node_modules/<@preact/preset-vite|vite-prerender-plugin>/headless-prerender/...) to allow users to use external, non-bundled node_modules whilst prerendering, but that screws with module resolution a tad. The demo will try to pull from that, but given it's just a holding place rather than an actual, installed module, that won't work.
Side effect of being monorepo-ish here.
Comment on lines
-21
to
-22
|
|
||
| // Head API |
There was a problem hiding this comment.
All of this can be tested upstream
JoviDeCroock
approved these changes
Jan 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved it into the Preact org just the other day (preactjs/vite-prerender-plugin) as I wanted to keep an agnostic package for users to install, but syncing back & forth with this repo was a bit rough. It also is complex enough to warrant a bigger test suite, something which probably shouldn't be added here.
So, this PR switches over to consume it, rather than have an internal copy. Should be easier to maintain in the future hopefully.