Adagio Rtd Provider: add missing signal at ortb2.site.ext.data.adg_rtd level

[osazos]

Type of change

• Bugfix

Description of change

Add the ortb2.site.ext.data.adg_rtd.pageviewId signal in the AdagioRtdProvider.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioRtdProvider.js has 8 duplicated lines with modules/adagioRtdProvider.js
• modules/adagioRtdProvider.js has 19 duplicated lines with modules/bliinkBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioRtdProvider.js has 8 duplicated lines with modules/adagioRtdProvider.js
• modules/adagioRtdProvider.js has 19 duplicated lines with modules/bliinkBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[patmmccann]

Hey @osazos , can you move your code block and this https://github.com/prebid/Prebid.js/blob/master/modules/bliinkBidAdapter.js#L136-L152 into a library and import in both places?

Thanks!

[osazos]

Yep I was thinking to create another PR but no prob to do it right now.

[patmmccann]

This is good to merge when conflicts resolve, nice fix!

[patmmccann]

Lgtm

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioBidAdapter.js has 15 duplicated lines with modules/adagioRtdProvider.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[patmmccann]

@osazos please clean that one up on your next submit, particularly as your users will tend to have both installed

Perhaps use libraries folder instead of utils for that one

Eg /libraries/adagioUtils/