-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenX Bid Adapter : support native #12625
Merged
patmmccann
merged 25 commits into
prebid:master
from
openx:EXCH-10877-add-support-for-native-imps
Jan 13, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c4fbc28
[EXCH-10877] Add support for native to OpenX bid adapter
gmiedlar-ox abfe5b0
Merge branch 'master' into EXCH-10877-add-support-for-native-imps
gmiedlar-ox 9e548a5
[EXCH-10877] Add unit tests for interpretResponse and native
gmiedlar-ox 55a23a5
[EXCH-10877] Fix formatting
gmiedlar-ox 0889166
[EXCH-10877] Add support for native to OpenX bid adapter
gmiedlar-ox ba54f2c
[EXCH-10877] Add unit tests for interpretResponse and native
gmiedlar-ox 6c39451
[EXCH-10877] Fix formatting
gmiedlar-ox c881386
Merge remote-tracking branch 'origin/EXCH-10877-add-support-for-nativ…
gmiedlar-ox 77648f0
Revert "Merge remote-tracking branch 'origin/EXCH-10877-add-support-f…
gmiedlar-ox b33ba81
[EXCH-10877] Add info about native support to the docs
gmiedlar-ox 6044ea0
[EXCH-10877] create const, use null instead of undefined
gmiedlar-ox ad05066
Merge branch 'master' into EXCH-10877-add-support-for-native-imps
gmiedlar-ox 2bcbb2a
[EXCH-10877] Add support for native to OpenX bid adapter
gmiedlar-ox 3629d50
[EXCH-10877] Add unit tests for interpretResponse and native
gmiedlar-ox 1d10835
[EXCH-10877] Fix formatting
gmiedlar-ox e17035d
[EXCH-10877] Add support for native to OpenX bid adapter
gmiedlar-ox ccbcf98
[EXCH-10877] Add unit tests for interpretResponse and native
gmiedlar-ox 100ffae
[EXCH-10877] Fix formatting
gmiedlar-ox 6a40ca2
Revert "Merge remote-tracking branch 'origin/EXCH-10877-add-support-f…
gmiedlar-ox 12cf332
[EXCH-10877] Add info about native support to the docs
gmiedlar-ox bbf0317
[EXCH-10877] create const, use null instead of undefined
gmiedlar-ox 63eb715
Merge remote-tracking branch 'origin/EXCH-10877-add-support-for-nativ…
gmiedlar-ox bd7a12e
[EXCH-10877] Fix merge issues
gmiedlar-ox 8f62f37
Merge branch 'master' into EXCH-10877-add-support-for-native-imps
gmiedlar-ox 156137d
[EXCH-10877] Use various params.platform in test
gmiedlar-ox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it comes to video we wanted to keep the implementation unchanged, so create separate bid request with video mediaType only. We didn't want to introduce two separate changes at once to our adapter. Also we're be changing it probably in near future as we start supporting multi-format requests.