Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33across ID System: Store hashed email when feature is enabled via config #12630

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

carlosfelix
Copy link
Contributor

@carlosfelix carlosfelix commented Jan 8, 2025

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Updated bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Save the hashed email in browser storage when it's provided via config option or global var.
Do not remove it if it's no longer provided, unless the absence of the main ID in the endpoint response indicates the opposite.

Documentation Change: prebid/prebid.github.io#5793

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncolletti ncolletti merged commit ea87c0e into prebid:master Jan 13, 2025
4 of 5 checks passed
@ncolletti ncolletti added the LGTM label Jan 13, 2025
therevoltingx pushed a commit to InteractiveAdvertisingBureau/Prebid.js that referenced this pull request Jan 14, 2025
…nfig (prebid#12630)

* Allow to read hashed email from 33across global

* refactoring of supplemental IDs

* store hashed email as another FP supplemental ID.

* split existing unit test about successful 33across ID system response.

* should clear hashed email if 33x response doesn't contain ID

* rename some of the internal 33x ID system variables

* code review feedback. HEM sources order & var rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants