-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPlanning Bid Adapter : adding support for schain #12635
Conversation
modules/eplanningBidAdapter.js
Outdated
@@ -70,7 +72,9 @@ export const spec = { | |||
if (pcrs) { | |||
params.crs = pcrs; | |||
} | |||
|
|||
if (Math.floor(Math.random() * 1000) === 0 && schain) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you sampling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As schain does not change all the time, we only need to receive it once every 1000 requests. Then we use a cache on our side until the next request. This way we reduce the requests size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might get different schains from different units on the same page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if someone sets an schain rid, it changes every time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We analyzed it and decided to remove the sampling and we will only send the information when the number of nodes is greater than 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the misunderstanding, I just discussed with my manager and what we need is to receive schain values when nodes are less or equal to 2. I just made a new pull request #12670.
Type of change
Description of change