Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubMatic Analytics Adapter: Moving slot level parameters to root level and adding few parameters to log in tracker #12665

Merged
merged 16 commits into from
Jan 21, 2025

Conversation

pm-priyanka-deshmane
Copy link
Contributor

Type of change

  • Feature

Description of change

  • Moved ffs,fsrc,fp fields to root level similar to server side profiles
  • Logging fv field as final floor value
  • Added fmv, fsrc, fp, ft, frv & fv in tracker call

Other information

Copy link

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • modules/pubmaticAnalyticsAdapter.js (+4 errors)

@patmmccann
Copy link
Collaborator

@pm-priyanka-deshmane please fix your linting errors

Copy link
Collaborator

@jlquaccia jlquaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and looks as though all checks are passing)

@jlquaccia jlquaccia merged commit 9355e47 into prebid:master Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants