Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMS Bid Adapter: add video support, test coverage and update documentation #12671

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

siminkovladyslav
Copy link
Contributor

Type of change

  • Feature

Description of change

  • Adding video support
  • Adding test coverage for video cases interpretResponse and buildRequests functions
  • Updating the documentation

Other information

PR with updating Prebid.org docs

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@ChrisHuie ChrisHuie changed the title OMS Adapter: add video support, test coverage and update documentation OMS Bid Adapter: add video support, test coverage and update documentation Jan 22, 2025
@ChrisHuie ChrisHuie self-assigned this Jan 22, 2025
@ChrisHuie ChrisHuie merged commit 65aade6 into prebid:master Jan 22, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants