Fix: setuid endpoint sets cookie when both GDPR and GPP are set #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P is set in the request
bsardo
reviewed
Nov 2, 2023
endpoints/setuid.go
Outdated
| w.Write([]byte("Warning: " + err.Error())) | ||
| w.Header().Add("Warning", err.Error()) |
There was a problem hiding this comment.
We'd rather not add a warning as a header. Instead, I think we should skip sending a warning in the response altogether. We can simply delete this line which should cause the endpoint to set the cookie when both GDPR and GPP are set.
I don't think this is necessarily required but you could explore adding a metric to surface the warning.
There was a problem hiding this comment.
as per the suggestion, removed the line
bsardo
changed the title
bsardo
changed the title
bsardo
previously approved these changes
Nov 27, 2023
endpoints/setuid_test.go
Outdated
| }, | ||
| { | ||
| uri: "/setuid?f=i&bidder=pubmatic&uid=123&gpp_sid=2,4&gpp=DBABMA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA" + | ||
| "gdpr=1&gdpr_consent=BONciguONcjGKADACHENAOLS1rAHDAFAAEAASABQAMwAeACEAFw", |
There was a problem hiding this comment.
Did you mean "&gdpr=1 at the beginning of the line?
There was a problem hiding this comment.
yes, added missing & separator
VeronikaSolovei9
approved these changes
Nov 30, 2023
bsardo
approved these changes
Dec 1, 2023
SuprPhatAnon
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for - #3166