Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTBHouse: native support (renewal) #3328

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

piotrj-rtbh
Copy link
Contributor

@piotrj-rtbh piotrj-rtbh commented Nov 29, 2023

Type of change

  • Feature
  • Code style update (formatting, local variables)
  • Bugfix

Description of change

This is a renewal of the PR #3212 which has been reverted by PR #3271. Making a new PR to re-merge the changes. Please do not port this feature to PBS Java (it's already there).

Native ads are now available to be processed and accessed by RTB House adapter. Test coverage has increased significantly.

There is also a little bugfix added to how the adapter handles bid floors. Previous version dropped bid floor defined in a bidder param ("bidfloor") when publishers didn't set currency module. Now it is fine with that case and the bidfloor currency is set to the bidder's default (USD).

Other information

Please reach us at [email protected] with [email protected] and cc [email protected].

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4525788

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:36:	MakeRequests		94.1%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:106:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:128:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:194:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:205:	getNativeAdm		100.0%
total:									(statements)		97.7%

@gargcreation1992 gargcreation1992 merged commit db74611 into prebid:master Dec 5, 2023
5 checks passed
SuprPhatAnon pushed a commit to GiftConnect/prebid-server that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants