ci: check shellscripts

I noticed that we don't really lint our shellscripts

.pre-commit-config.yaml

@@ -35,6 +35,13 @@ repos:
         types_or: [python, pyi]
         require_serial: true
         stages: [pre-commit, manual]
+      # Shellcheck
+      - id: shellcheck
+        name: Check shell scripts
+        entry: pixi run --environment=lint shellcheck
+        language: system
+        types: [shell]
+        stages: [pre-commit, manual]
       # GitHub Actions
       - id: actionlint
         name: Lint GitHub Actions workflow files

examples/pypi/activate.sh

@@ -1 +1,3 @@
+#!/usr/bin/env bash
+
 export MY_SUPER_ENV=hello

install/install.sh

@@ -39,7 +39,7 @@ else
   DOWNLOAD_URL="https://github.com/${REPO}/releases/download/${VERSION}/${BINARY}.${EXTENSION}"
 fi
 
-printf "This script will automatically download and install Pixi (${VERSION}) for you.\nGetting it from this url: $DOWNLOAD_URL\n"
+printf "This script will automatically download and install Pixi (%s) for you.\nGetting it from this url: %s\n" "$VERSION" "$DOWNLOAD_URL"
 
 if ! hash curl 2> /dev/null && ! hash wget 2> /dev/null; then
   echo "error: you need either 'curl' or 'wget' installed for this script."
@@ -125,7 +125,7 @@ update_shell() {
     LINE="$2"
 
     # shell update can be suppressed by `PIXI_NO_PATH_UPDATE` env var
-    [[ ! -z "${PIXI_NO_PATH_UPDATE:-}" ]] && echo "No path update because PIXI_NO_PATH_UPDATE has a value" && return
+    [[ -n "${PIXI_NO_PATH_UPDATE:-}" ]] && echo "No path update because PIXI_NO_PATH_UPDATE has a value" && return
 
     # Create the file if it doesn't exist
     if [ -f "$FILE" ]; then

src/shell_snippets/pixi-bash.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 pixi() {
     local first_arg="$1"
     local cmd="$PIXI_EXE $*"

src/shell_snippets/pixi-zsh.sh

@@ -1,3 +1,4 @@
+# shellcheck disable=all
 pixi() {
     local first_arg="$1"
     local cmd="$PIXI_EXE $*"

tests/data/channels/recipes/trampoline/print_path.sh

@@ -1,3 +1,3 @@
 #!/bin/bash
 
-echo $PATH
+echo "$PATH"

tests/scripts/test-export.sh

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 # Run from the root of the project using `bash tests/test_export.sh`
 set -e
 set -x