-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pixi add git source dependency #2858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-arts
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this works great!
Could you add some documentation of the CLI and get it working for pypi
aswell?
ruben-arts
reviewed
Jan 9, 2025
ruben-arts
reviewed
Jan 9, 2025
ruben-arts
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me.
… feat/pixi-add-git-spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2795
Overview
Extend pixi add to support git source dependencies.
pixi add --git --branch/--rev/--tag --subdir
To test it, you can
cd examples/pixi-build/cpp-sdl
and run:pixi add --git https://github.com/wolfv/pixi-build-examples --branch main --subdir boost-check boost-check
or select a different commit/tag.
Some implementation details/choices:
Manifest.add_dependency
now acceptsPixiSpec
andPackageName
instead of Matchspec. This allows in my opinion to be more flexible when adding pixi specs into manifest, as PixiSpec can represent SourceSpec/BinSpec and move the responsibility of creating it to the caller side rather than manifest side. It also savesmanifest
to not acceptChannelConfig
project.update_dependencies now accept also
SourceSpec
.We also support adding git for pypi: