Fix gmake/gmake2 action mixing up compilers
#2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
force-pushed
the
fix-default-gcc-toolset
branch
from
053dc78 to
14fd9d3
Compare
|
By the way, this mix up of compilers manifests itself in practice as some real weird debugging interactions, in my case with LLDB (not sure if GDB is the same case). Some breakpoints would not get it, its really annoying to encounter and figure out whats going on. |
Jarod42
reviewed
Sep 1, 2024
tritao
force-pushed
the
fix-default-gcc-toolset
branch
from
14fd9d3 to
c2a9b67
Compare
|
Updated with review feedback addressed. |
tritao
changed the title
gmake/gmake2 action mixing up compilers from different toolsets.gmake/gmake2 action mixing up compilers
Jarod42
approved these changes
Sep 2, 2024
Due to Make behavior, specifically its default values to the CC and CXX implicit rules, we could end up in a scenario where the gcc and clang compilers would be used in the same project. Be more explicit and do not rely on using the system default compilers, and use the gcc and g++ compilers explicitly.
tritao
force-pushed
the
fix-default-gcc-toolset
branch
from
c2a9b67 to
fc95dde
Compare
|
Updated the PR with latest feedback. |
nickclark2016
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Make behavior, specifically its default values to the CC and CXX implicit rules, we could end up in a scenario where the gcc and clang compilers would be used in the same project.
Be more explicit and do not rely on using the system default compilers, and use the
gccandg++compilers explicitly.Fixes #2207.