This repository has been archived by the owner on Nov 23, 2018. It is now read-only.
Upgraded mime-types, fixed url underscores, fix blank? not defined #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE....
Hi!
You probably don't want to merge this PR outright, but I hope it gives you some ideas. I had to fork your repo and make these changes to get them to work for a project I'm working on. The issues were:
Anyway, if you like, I can clean up #1 and #2 so that they are merge-able... i.e. not just check for nil but also check for empty... maybe something like: self.region.to_s.empty? which would work if self.region is nil or self.region is an empty string.