Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompile overlay 30 (saving app on touch screen) #257

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

tgsm
Copy link
Collaborator

@tgsm tgsm commented Oct 12, 2023

No description provided.

Copy link
Member

@red031000 red031000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the overlay is very odd and doesn't follow GF's normal gen 4 overlay structure, hence the funcs I'd normally label as Init, Main, and Exit I haven't commented on

@@ -729,7 +729,7 @@ ov01_02206C08: ; 0x02206C08

ov01_02206C60: ; 0x02206C60
.word ov27_02259F80, ov27_0225A19C, ov27_0225A2C8, 0xFFFFFFFF
.word ov30_0225D520, ov30_0225D64C, ov30_0225D6FC, FS_OVERLAY_ID(OVY_30)
.word ov30_0225D520, ov30_0225D64C, ov30_0225D6FC, FS_OVERLAY_ID(touch_save_app)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOUCH_SAVE_APP or touch_save_app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as has been done for other overlays already, touch_save_app

src/touch_save_app.c Outdated Show resolved Hide resolved
src/touch_save_app.c Show resolved Hide resolved
src/touch_save_app.c Outdated Show resolved Hide resolved
src/touch_save_app.c Outdated Show resolved Hide resolved
src/touch_save_app.c Show resolved Hide resolved
src/touch_save_app.c Outdated Show resolved Hide resolved
src/touch_save_app.c Outdated Show resolved Hide resolved
static void TouchSaveApp_SetupGraphics(TouchSaveAppData *data) {
G2S_BlendNone();

GfGfxLoader_LoadCharData(NARC_a_0_1_4, 76, data->bgConfig, GF_BG_LYR_SUB_0, 0, 0, TRUE, HEAP_ID_8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally use the naix constants, not sure if a narcs can do that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can if you dump the NARC, however I have no idea what to name it or where to put it

src/touch_save_app.c Outdated Show resolved Hide resolved
src/touch_save_app.c Outdated Show resolved Hide resolved
@tgsm
Copy link
Collaborator Author

tgsm commented Nov 4, 2023

Will rebase when #263 is merged.

{
After OVY_27
Object asm/overlay_30.o
Object src/touch_save_app.o
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna use this opportunity to discuss whether overlays should be in their own folder, makes sense for stuff like battle, but tbh I feel like for every overlay they should be in their own folder (and possible all the folders in an overlays folder)

@cbt6
Copy link
Contributor

cbt6 commented Nov 12, 2023

Delete asm/overlay_30.s and asm/include/overlay_30.inc.

@red031000 red031000 merged commit a2a1aaa into pret:master Nov 16, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
@tgsm tgsm deleted the touch-save-app branch November 16, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants