-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompile overlay 30 (saving app on touch screen) #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the overlay is very odd and doesn't follow GF's normal gen 4 overlay structure, hence the funcs I'd normally label as Init, Main, and Exit I haven't commented on
@@ -729,7 +729,7 @@ ov01_02206C08: ; 0x02206C08 | |||
|
|||
ov01_02206C60: ; 0x02206C60 | |||
.word ov27_02259F80, ov27_0225A19C, ov27_0225A2C8, 0xFFFFFFFF | |||
.word ov30_0225D520, ov30_0225D64C, ov30_0225D6FC, FS_OVERLAY_ID(OVY_30) | |||
.word ov30_0225D520, ov30_0225D64C, ov30_0225D6FC, FS_OVERLAY_ID(touch_save_app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOUCH_SAVE_APP or touch_save_app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as has been done for other overlays already, touch_save_app
static void TouchSaveApp_SetupGraphics(TouchSaveAppData *data) { | ||
G2S_BlendNone(); | ||
|
||
GfGfxLoader_LoadCharData(NARC_a_0_1_4, 76, data->bgConfig, GF_BG_LYR_SUB_0, 0, 0, TRUE, HEAP_ID_8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally use the naix constants, not sure if a narcs can do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can if you dump the NARC, however I have no idea what to name it or where to put it
Will rebase when #263 is merged. |
{ | ||
After OVY_27 | ||
Object asm/overlay_30.o | ||
Object src/touch_save_app.o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna use this opportunity to discuss whether overlays should be in their own folder, makes sense for stuff like battle, but tbh I feel like for every overlay they should be in their own folder (and possible all the folders in an overlays folder)
Delete |
No description provided.