Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompile overlay_25 #258

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Decompile overlay_25 #258

merged 6 commits into from
Oct 20, 2023

Conversation

cbt6
Copy link
Contributor

@cbt6 cbt6 commented Oct 17, 2023

No description provided.

tgsm
tgsm requested changes Oct 17, 2023
View reviewed changes
include/overlay_25.h Outdated Show resolved Hide resolved
src/overlay_25.c Outdated Show resolved Hide resolved
src/overlay_25.c Outdated Show resolved Hide resolved
src/overlay_25.c Outdated Show resolved Hide resolved
src/overlay_25.c Outdated Show resolved Hide resolved
@cbt6 cbt6 requested a review from tgsm October 18, 2023 00:25
tgsm
tgsm previously approved these changes Oct 18, 2023
View reviewed changes
red031000
red031000 requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@red031000 red031000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things, need discussing whether appropriate

src/overlay_25.c Outdated Show resolved Hide resolved
src/overlay_25.c Outdated Show resolved Hide resolved
src/overlay_25.c Outdated Show resolved Hide resolved
src/overlay_25.c Show resolved Hide resolved
@cbt6 cbt6 requested a review from red031000 October 18, 2023 14:50
red031000
red031000 requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@red031000 red031000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see where you renamed the scrcmd in scrcmd.c? I see it in the headers but not in the c file? possible that github is playing up?

@cbt6
Copy link
Contributor Author

cbt6 commented Oct 20, 2023

Are you referring to ScrCmd_ShowTrainerHouseIntroMessage? That's in src/overlay_25.c

@red031000
Copy link
Member

odd that it's not in an scrcmd file

@red031000 red031000 merged commit 3a18972 into pret:master Oct 20, 2023
1 check passed
@cbt6 cbt6 deleted the overlay_25 branch October 20, 2023 14:37
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
@red031000
Merge pull request #258 from cbt6/overlay_25
b11d616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red031000 red031000 red031000 approved these changes

@tgsm tgsm tgsm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbt6 @red031000 @tgsm