-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exp Task #264
Exp Task #264
Conversation
rebase pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many to list but use constants for message ids, e.g.:
-msg.id = 1; // "{0} gained {1} Exp. Points!"
+msg.id = msg_0197_00001;
-msg.id = 1179; // "But {0} can't learn more than four moves."
+msg.id = msg_0197_01179;
-BattleController_EmitDrawYesNoBox(data->bsys, data->ctx, expBattler, 1180, 1, 0, 0);
+BattleController_EmitDrawYesNoBox(data->bsys, data->ctx, expBattler, msg_0197_01180, 1, 0, 0);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wew thats a long one
since I'm not gonna be finishing it this pr and want to keep track for later
Co-authored-by: Thomas <[email protected]>
Co-authored-by: Thomas <[email protected]>
Co-authored-by: Thomas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also debating about the renaming of bsys to battleSystem and int to s32 but that's technically out of scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor things, but provided more isn't changed/added after these are addressed, I'd say it's ready to merge
Co-authored-by: PikalaxALT <[email protected]>
Co-authored-by: PikalaxALT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please please please don't add more after addressing this review, otherwise we'll be stuck in an endless cycle of you addressing, then adding more, then I review, and you address, and add more etc.
No description provided.