feat: add client internal query params #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated as per discussion 👌 |
This reverts commit d2cf531.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 70 61 -9
Lines 2550 1987 -563
Branches 516 382 -134
==========================================
- Hits 2550 1987 -563 ☔ View full report in Codecov by Sentry. |
|
Refactored as per discussions! (thanks, it's much leaner like this 🙏) Let me know about it and I'm happy to ship afterward :) |
lihbr
changed the title
lihbr
changed the title
angeloashmore
approved these changes
Sep 5, 2024
Co-authored-by: Angelo Ashmore <[email protected]>
Co-authored-by: Angelo Ashmore <[email protected]>
|
Thanks, let's release that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: N/A
Description
This pull request adds support for client internal query parameters for the API to use. For more context, see: https://prismic-team.slack.com/archives/C030DCL4JNR/p1724406092961109
x-dis forwarded whenprocess.env.NODE_ENV === "developmentx-cis forwarded with the attached client versionChecklist
Preview
N/A
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩