Skip to content

Commit

Permalink
keep invisible opcs in lod to enable fast switching, see #484 & versi…
Browse files Browse the repository at this point in the history
…on bump
  • Loading branch information
haraldsteinlechner committed Jan 5, 2025
1 parent 21b874d commit 21cd88f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions TEST_RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 4.27.0-prerelease2
- fixed lod when switching surfaces visible/invisible (keep invisible opcs in lod, to make fast switching possible)

## 4.27.0-prerelease1
- coordinate frames as scale bars
- fixed memory leak for high focal length fulcra
Expand Down
6 changes: 4 additions & 2 deletions src/PRo3D.Core/Surface/Surface.Sg.fs
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,10 @@ module Sg =
(isActive : aval<bool>)
=

let isRenderingActive = isActive.GetValue self
if isRenderingActive then
let isRenderingActive =
//isActive.GetValue self, using isActive (actually is invisible) is not possible here, see https://github.com/pro3d-space/PRo3D/issues/484
true
if isRenderingActive then
let lodParams = lodParams.GetValue self
let viewTrafo = viewTrafo.GetValue self
let model = preTrafo * renderPatch.trafo.GetValue self
Expand Down

0 comments on commit 21cd88f

Please sign in to comment.