chore(deps-dev): bump to ESLint v9 #3081

csouchet · 2024-04-22T09:07:01Z

In ESLint v9, we must have only one configuration file.

Some dependencies don't support officially ESLint v9, but it works 😊

ℹ️ ESLint 8 has been EOL since October 5, 2024.
https://eslint.org/blog/2024/09/eslint-v8-eol-version-support/#eslint-v8.x-end-of-life-is-october-5%2C-2024

Need to support ESLint v9:

✅ typescript-eslint V8: https://typescript-eslint.io/blog/announcing-typescript-eslint-v8

❌ https://github.com/sindresorhus/eslint-plugin-unicorn (but supports flat config)

✅ eslint-plugin-playwright: https://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#usage

✅ https://github.com/prettier/eslint-plugin-prettier: https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs

✅ https://github.com/prettier/eslint-config-prettier: https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs

❌ eslint-plugin-jest:

npm error Conflicting peer dependency: [email protected]  
npm error node\_modules/eslint  
npm error   peer eslint@"^8.56.0" from @typescript-eslint/[email protected]  
npm error   node\_modules/@typescript-eslint/eslint-plugin  
npm error     peerOptional @typescript-eslint/eslint-plugin@"^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]  
npm error     node\_modules/eslint-plugin-jest  
npm error       dev eslint-plugin-jest@"~28.8.3" from the root project

✅ eslint-plugin-jest-extended: https://github.com/jest-community/eslint-plugin-jest/blob/main/src/index.ts

✅ eslint-plugin-import: https://github.com/import-js/eslint-plugin-import?tab=readme-ov-file#config---flat-eslintconfigjs

❌ eslint-import-resolver-typescript:

✅ eslint-plugin-notice: https://github.com/nickdeis/eslint-plugin-notice?tab=readme-ov-file#flag-config

github-actions · 2024-10-08T09:39:07Z

🎊 PR Preview 63e555c has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3081.surge.sh

🕐 Build time: 0.011s

_{🤖 By surge-preview}

github-actions · 2024-10-08T09:39:16Z

🎊 PR Preview 63e555c has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3081.surge.sh

🕐 Build time: 0.011s

_{🤖 By surge-preview}

package.json

Bumps the lint group with 6 updates: | Package | From | To | | --- | --- | --- | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `7.4.0` | `7.6.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `7.4.0` | `7.6.0` | | [eslint](https://github.com/eslint/eslint) | `8.57.0` | `9.0.0` | | [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `27.9.0` | `28.2.0` | | [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) | `1.5.4` | `1.6.0` | | [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) | `51.0.1` | `52.0.0` | Updates `@typescript-eslint/eslint-plugin` from 7.4.0 to 7.6.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.6.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 7.4.0 to 7.6.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.6.0/packages/parser) Updates `eslint` from 8.57.0 to 9.0.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.0.0) Updates `eslint-plugin-jest` from 27.9.0 to 28.2.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v27.9.0...v28.2.0) Updates `eslint-plugin-playwright` from 1.5.4 to 1.6.0 - [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases) - [Changelog](https://github.com/playwright-community/eslint-plugin-playwright/blob/main/CHANGELOG.md) - [Commits](playwright-community/eslint-plugin-playwright@v1.5.4...v1.6.0) Updates `eslint-plugin-unicorn` from 51.0.1 to 52.0.0 - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v51.0.1...v52.0.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint - dependency-name: eslint-plugin-jest dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint - dependency-name: eslint-plugin-playwright dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: eslint-plugin-unicorn dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint ... Signed-off-by: dependabot[bot] <[email protected]>

tbouffard

Thanks for this PR, this has been a long running task 🎉

It is going to take me some time to review the migration to the flat config and test that the configuration is working as before.
I will try to review the PR in the next days/weeks

test/bundles/jest.config.cjs

tbouffard · 2025-01-13T08:05:43Z

test/config/jest-playwright.cjs

@@ -110,7 +110,7 @@ const computeConfigurationForDevelopmentServerUsage = defaultBrowsers => {
 const computeConfiguration = options => {
  let configuration;
  configuration =
-    (options.startWebServer ?? true) ? computeConfigurationForDevelopmentServerUsage(options.defaultBrowsers) : computeConfigurationForStaticUsage(options.defaultBrowsers);
+    options.startWebServer || true ? computeConfigurationForDevelopmentServerUsage(options.defaultBrowsers) : computeConfigurationForStaticUsage(options.defaultBrowsers);


nitpick: I don't know if this change is due to a new eslint rule but IMHO, this introduce a behavior change.

Previously, the value was true only if the startWebServer option was nullish (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing).
The logic has been changed here to use a logical OR operator (falsy check instead of nullish check). Now, if the startWebServer option is false, the computed value is true as well. So the check is completely useless as the condition is always evaluated to true.

Yes, is due to the rule. Maybe, we need to disable this rule on .cjs file.

After checking, it's not a rule who fails, but the ECMA version used in ESLint.
If we want to keep ??, we need to upgrade the used ECMA version.
Maybe, it works with ESLint v8, because of a bug (or, there is a bug in ESLint v9).

Yes this is weird, as you mentioned, we should have been forced to set ecmaVersion: 2020 (instead of 2018, the operator was introduced in 2020) in the former configuration.
Can we set it now to 2020 to be able to restore the usage for Nullish coalescing operator?

Yes, the Nullish coalescing operator works fine with ECMA 2020.

tbouffard · 2025-01-13T08:07:24Z

test/typescript-support/src/index.ts

@@ -14,7 +14,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */

-// eslint-disable-next-line import/no-unresolved -- The bpmn-visualization package may not have been built prior running eslint (it happens when running GitHub Actions)


thought: for me only, I will check the commit history to understand why we introduce it and why this seems no longer necessary.

[no ci]

…oalescing operator

sonarqubecloud · 2025-01-17T10:26:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

csouchet added the dependencies Pull requests that update a dependency (dev or runtime) label Apr 22, 2024

csouchet force-pushed the chore/eslint9 branch 2 times, most recently from 43d040b to 32284cc Compare April 22, 2024 10:26

csouchet force-pushed the chore/eslint9 branch from 32284cc to 230c27f Compare May 24, 2024 08:01

csouchet changed the title ~~chore(dev-deps): Bump to ESLint 9.1.0~~ chore(dev-deps): Bump to ESLint v9 May 24, 2024

tbouffard changed the title ~~chore(dev-deps): Bump to ESLint v9~~ chore(dev-deps): bump to ESLint v9 May 24, 2024

csouchet force-pushed the chore/eslint9 branch from 230c27f to 1c596eb Compare July 11, 2024 16:25

tbouffard changed the title ~~chore(dev-deps): bump to ESLint v9~~ chore(deps-dev): bump to ESLint v9 Aug 2, 2024

csouchet force-pushed the chore/eslint9 branch from 1c596eb to b390ca9 Compare October 8, 2024 09:38

tbouffard reviewed Oct 8, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

tbouffard reviewed Oct 8, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

csouchet force-pushed the chore/eslint9 branch from eff6143 to 1b689f1 Compare October 8, 2024 14:30

tbouffard added the skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) label Oct 21, 2024

csouchet force-pushed the chore/eslint9 branch 2 times, most recently from 91de37e to b61d045 Compare October 29, 2024 15:32

csouchet force-pushed the chore/eslint9 branch 2 times, most recently from 41d62b4 to 4a843ec Compare November 18, 2024 15:22

csouchet force-pushed the chore/eslint9 branch from 4a843ec to 644c7af Compare December 6, 2024 09:33

dependabot bot and others added 10 commits January 7, 2025 09:56

replace the old dependencies for typescript-eslint by the new

a0c4cd2

rename the eslint config file

f179b53

Migrate the plugin

cc0e70a

migrate parserOptions

53e3c82

migrate extends

84f470f

migrate overrides

8145241

migrate ignore

9976840

wip: fix conf

97dec41

bump dependencies for eslint

a58e0f8

csouchet added 2 commits January 7, 2025 10:00

disabled 'import/no-unresolved' for .mjs files

1758ddb

bump eslint dependencies

9ddc5a0

csouchet force-pushed the chore/eslint9 branch from 644c7af to 9ddc5a0 Compare January 7, 2025 09:03

csouchet added 11 commits January 7, 2025 10:12

fix ignored patterns

fbde9b5

fix import plugin in eslint config.

d717a45

use extends feature of flat config for eslint

99c5d68

fix import/namespace

6a560bd

change configuration order

1da63f1

Disable 'unicorn/numeric-separators-style' for JS files

b2d7b2a

no ?? in cjs files. replace by ||

1044c22

replace @typescript-eslint/no-loss-of-precision by no-loss-of-precision

be82526

Disable 'unicorn/prefer-optional-catch-binding' on JS files

0505c73

in eslint v9, we can only have one file of configuration.

6e20074

ignore test/typescript-support/*

ec652da

csouchet removed the skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) label Jan 7, 2025

revert some changes

a1dbdbe

csouchet force-pushed the chore/eslint9 branch from bcc2cc8 to a1dbdbe Compare January 7, 2025 16:18

csouchet marked this pull request as ready for review January 7, 2025 16:31

csouchet requested a review from tbouffard January 7, 2025 16:31

tbouffard reviewed Jan 13, 2025

View reviewed changes

simplify timeout in milliseconds

e675e33

[no ci]

tbouffard added the skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) label Jan 13, 2025

csouchet marked this pull request as draft January 16, 2025 16:50

csouchet and others added 4 commits January 16, 2025 17:53

Merge remote-tracking branch 'origin/master' into chore/eslint9

f51263a

bump eslint dependencies

16681cc

Upgrade ECMA version to 2020 in ESLint to keep the usage of Nullish c…

8b1de4f

…oalescing operator

Merge branch 'master' into chore/eslint9

63e555c

csouchet marked this pull request as ready for review January 17, 2025 10:24

csouchet requested a review from tbouffard January 17, 2025 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps-dev): bump to ESLint v9 #3081

chore(deps-dev): bump to ESLint v9 #3081

csouchet commented Apr 22, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

tbouffard left a comment

tbouffard Jan 13, 2025

csouchet Jan 13, 2025

csouchet Jan 16, 2025

tbouffard Jan 17, 2025 •

edited

Loading

csouchet Jan 17, 2025

tbouffard Jan 13, 2025

sonarqubecloud bot commented Jan 17, 2025

chore(deps-dev): bump to ESLint v9 #3081

Are you sure you want to change the base?

chore(deps-dev): bump to ESLint v9 #3081

Conversation

csouchet commented Apr 22, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 • edited Loading

tbouffard left a comment

Choose a reason for hiding this comment

tbouffard Jan 13, 2025

Choose a reason for hiding this comment

csouchet Jan 13, 2025

Choose a reason for hiding this comment

csouchet Jan 16, 2025

Choose a reason for hiding this comment

tbouffard Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

csouchet Jan 17, 2025

Choose a reason for hiding this comment

tbouffard Jan 13, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 17, 2025

Quality Gate passed

csouchet commented Apr 22, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

tbouffard Jan 17, 2025 •

edited

Loading