New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buildGeometry absorbing the ambient fill color #7489

Merged

davepagurek merged 1 commit into dev-2.0 from fix/geom-default-color

Jan 22, 2025

+31 −3

Contributor

davepagurek commented Jan 22, 2025

Changes:

An intended change in 2.0 was to make it so that when you call model() on a shape made in buildGeometry, it will take on whatever the fill colour currently is, unless you manually set a fill color within buildGeometry.
This functionality stopped working after we changed how the renderers manage their fill/stroke color
This restores the expected behaviour.


          Fix p5.Geometry absorbing the ambient fill color

45b02f8

davepagurek merged commit c7ee241 into dev-2.0

2 checks passed

davepagurek deleted the fix/geom-default-color branch

January 22, 2025 22:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet