Replace Windows CI workflow with #165 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this may be slow, but will avoid double zipping in the .zip (but not for the .nupkg, alas)
tahina-pro
force-pushed
the
_taramana_windows_ci
branch
from
980a72b to
7ed31d4
Compare
mtzguido
reviewed
Jan 22, 2025
| uses: actions/checkout@v4 | ||
| with: | ||
| sparse-checkout: src\3d\tests | ||
| path: ${{ github.workspace }}\everparse |
There was a problem hiding this comment.
I think you may not need all the github.workspace mentions here, it should be the directory where the runner is currently at. This is not so in the self-hosted runner only due to using a --login shell, I think.
There was a problem hiding this comment.
Thanks for your remark. However, I remember having issues with relative paths, so I inserted those absolute paths in a47be5e. I believe using explicit paths like those help maintaining the workflow and avoid relying on implicit knowledge of who works where.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old Windows CI workflow was relying on a full build of F* from scratch, which is (currently) not possible on Windows. So, we need to disable it, and to replace it with the workflow that @mtzguido introduced in #165 and that builds a F* source package on Linux (or downloads a cached one) and then compiles that source package on Windows with EverParse.