Update dispatch logic in nftables #9323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
caseydavenport
force-pushed
the
casey-nft-dispatch
branch
2 times, most recently
from
5dd25a8 to
cfe6c1c
Compare
caseydavenport
added
the
release-note-not-required
marvin-tigera
removed
the
release-note-required
caseydavenport
changed the title
caseydavenport
commented
Oct 18, 2024
caseydavenport
force-pushed
the
casey-nft-dispatch
branch
2 times, most recently
from
a2bd27e to
dae33d7
Compare
caseydavenport
force-pushed
the
casey-nft-dispatch
branch
from
cb37ef4 to
663455b
Compare
caseydavenport
force-pushed
the
casey-nft-dispatch
branch
2 times, most recently
from
234a737 to
7d1c1a8
Compare
caseydavenport
force-pushed
the
casey-nft-dispatch
branch
from
7d1c1a8 to
c27ae59
Compare
fasaxc
requested changes
Dec 9, 2024
fasaxc
reviewed
Dec 9, 2024
fasaxc
reviewed
Dec 11, 2024
|
@fasaxc thanks for the reviews! I've updated to use |
fasaxc
requested changes
Jan 7, 2025
fasaxc
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update dispatch logic in nftables mode to use verdict maps instead of a list of dispatch chains.
Using verdict maps allows us to look up the correct policy rules to execute in constant time, instead of traversing a list of chains proportional to the number of locally running pods.
I expect the savings here to be minimal in most cases - iptables mode already mitigates this by using a dispatch trie to minimize the number rules traversed. Still worthwhile, especially as the number of pods per node some users are pushing grows over time.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.