[release tool] fix hashrelease hanging on image checks #9681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
radTuti
added
docs-not-required
marvin-tigera
removed
release-note-required
radTuti
commented
Jan 7, 2025
| for name, component := range r.imageComponents { | ||
| go imgExists(name, component, ch) | ||
| } | ||
| for range images { |
There was a problem hiding this comment.
I think this should be for range r.imageComponents - the thing is that we're waiting for each started goroutine to finish, and we know we launched r.imageComponents goroutines. That would probably fix the original deadlock IIUC
coutinhop
reviewed
Jan 8, 2025
coutinhop
approved these changes
Jan 8, 2025
caseydavenport
requested changes
Jan 8, 2025
radTuti
force-pushed
the
hashrelease-fix
branch
from
efeeab9 to
966f7a7
Compare
caseydavenport
approved these changes
Jan 8, 2025
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Jan 9, 2025
…#9681) * rewrite image check with timeout * pass components list to manager * cleanup * address review feedback
3 tasks
coutinhop
pushed a commit
that referenced
this pull request
Jan 9, 2025
* [release tool] restructure: main.go (#9565) * rename release/build to release/cmd build was a folder name for using goyek; cmd is the proper way * resturture main.go - create Command interface to return subcommands - move each subcommand to separate file - create flags.go to house all flags * fix release build * Apply suggestions from code review Co-authored-by: Casey Davenport <[email protected]> * move cmd definitions to own files --------- Co-authored-by: Casey Davenport <[email protected]> * [release tool] remove config package (#9578) * switch to flags instead of using config package * clean ups - minimize hardcoded strings - reduce info logs - created shared.go for fns used across commands * trim fat and address review feedback * keep repoRoot as internal config * [release tool] refactor pinnedversion (#9595) * refactor pinnedversion ref: DE-2970 * address review * [release tool] pass in GitHub token as flag for actual release (#9596) * pass in GitHub token as flag for actual release * CI fix * [release-tool] refactor update branch command and manager (#9616) * update branching and versioning * address review feedback * [release tool] refactor generating hashrelease and release (#9634) * refactor generating hashrelease and release * CI fix * cleanup - remove copying pinned version to hashrelease dir - removed hard-coded string - simplify code generation * minor fix * address review * [release tool] fix hashrelease failure (#9661) * fix checking if hashrelease already exists * split hashrelease commands * address review feedback * Load value from metadata.mk in release tool (#9659) * fix hashrelease local src directory (#9673) * [release tool] fix hashrelease hanging on image checks (#9681) * rewrite image check with timeout * pass components list to manager * cleanup * address review feedback --------- Co-authored-by: Casey Davenport <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The components were not being pased on for hashrelease publish leading to the goroutine getting stuck waiting for results.
This adds timeout to each image check, includes more logs and validation checks during that process.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.