Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StripTrailingHostDot: Expose new configuration option to enable Envoy removal of trailing dot on hostnames #6792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Add strip trailing host dot option from Envoy

7f1150b
Select commit
Loading
Failed to load commit list.
Open

StripTrailingHostDot: Expose new configuration option to enable Envoy removal of trailing dot on hostnames #6792

Add strip trailing host dot option from Envoy
7f1150b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

81.06% (+0.00%) compared to 63bb34a

View this Pull Request on Codecov

81.06% (+0.00%) compared to 63bb34a

Details

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (63bb34a) to head (7f1150b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
cmd/contour/serve.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6792   +/-   ##
=======================================
  Coverage   81.05%   81.06%           
=======================================
  Files         133      133           
  Lines       20026    20037   +11     
=======================================
+ Hits        16232    16242   +10     
- Misses       3500     3501    +1     
  Partials      294      294           
Files with missing lines Coverage Δ
cmd/contour/servecontext.go 84.54% <100.00%> (+0.03%) ⬆️
internal/contourconfig/contourconfiguration.go 98.19% <100.00%> (+0.01%) ⬆️
internal/envoy/v3/listener.go 98.50% <100.00%> (+<0.01%) ⬆️
internal/xdscache/v3/listener.go 92.05% <100.00%> (+0.06%) ⬆️
pkg/config/parameters.go 88.09% <100.00%> (+0.03%) ⬆️
cmd/contour/serve.go 21.72% <0.00%> (-0.03%) ⬇️