Nested children support in overlays #521
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible for translations to contain nested markup tags, like so:
It also fixes the test which explicitly checks that this doesn't work, because that test was broken and incorrectly still passed after making this change. ¯\_(ツ)_/¯ That's a separate commit though, so it can be picked out if desired.
Current state of tests: all tests pass, except the one which explicitly disallows this behaviour (obviously), as I'm not sure whether there's a specific reason why nested children have not been allowed up til now. I have not added new tests for this functionality, as I find it very frustrating to deal with TS and again, I have no idea whether this PR will be accepted or not :)
So yeah, this is a bit of a draft PR, I suppose. I need this in my own application (for basic Markdown support in translation strings), hence having created a fork, but I don't know whether you're also interested in it as the upstream.