Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for legacy image field for image specifications #133

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

simu
Copy link
Member

@simu simu commented Nov 20, 2023

The image field was deprecated in component version v6. We now remove the field, so we can do the roll out of ArgoCD v2.9 with the new Kapitan sidecar plugin which uses a different container image with as little manual configuration as possible.

Follow-up to #128

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@simu simu added the breaking label Nov 20, 2023
@simu simu force-pushed the remove-image-field branch from 61de5d4 to 50a6c89 Compare November 20, 2023 10:24
@simu simu requested a review from a team November 20, 2023 10:24
@simu simu force-pushed the remove-image-field branch from 50a6c89 to c517575 Compare November 21, 2023 08:21
The `image` field was deprecated in component version v6. We now remove
the field, so we can do the roll out of ArgoCD v2.9 with the new Kapitan
sidecar plugin which uses a different container image with as little
manual configuration as possible.
@simu simu force-pushed the remove-image-field branch from c517575 to 29c7a5f Compare November 21, 2023 08:23
@simu simu merged commit 7b1a9d8 into master Nov 21, 2023
10 checks passed
@simu simu deleted the remove-image-field branch November 21, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants