-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetworkPolicies to isolate ArgoCD from rest of cluster #166
Conversation
fb8981d
to
3480ea3
Compare
I figured that for non-openshift, we can specify the monitoring NS via RKE is as yet untested though; gonna do that on Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For setups which use component-prometheus, we should be able to generate the correct NetworkPolicy for the monitoring stack via component-prometheus's component library with prometheus.NetworkPolicy()
, see also the example in https://hub.syn.tools/prometheus/how-tos/cluster-monitoring.html#_advertise_metrics_from_a_component
3480ea3
to
a63dfa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured that for non-openshift, we can specify the monitoring NS via allow_from_namespaces. I didn't feel like cross-pulling that info from all over the hierarchy.
As mentioned in the previous review comment already, we should use prometheus.NetworkPolicy()
which exists exactly so that components can provide seamless integration with component-prometheus instead of requiring users of component-prometheus to explicitly configure their Prometheus namespace when network policies are enabled, especially since we already handle the other half of it by wrapping the namespace in prometheus.RegisterNamespace()
when component-prometheus is installed on the cluster.
Co-authored-by: Simon Gerber <[email protected]>
Template version: main (26ee71e)
Template version: main (26ee71e)
Template version: main (26ee71e)
I should learn how to read 🙈 |
No bump labels present 🛠️ Auto tagging disabled |
naw I did it wrong |
Implements #149
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.