Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding configuration for syn-argocd #203

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Nov 7, 2024

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the enhancement New feature or request label Nov 7, 2024
@DebakelOrakel DebakelOrakel changed the title Support RBAC and SSO configuration for syn-argocd Support overriding configuration for syn-argocd Nov 7, 2024
@DebakelOrakel DebakelOrakel requested a review from a team November 7, 2024 14:54
@simu
Copy link
Member

simu commented Nov 8, 2024

I like this approach because it will allow us to test arbitrary argocd configurations without having to touch the component.

@DebakelOrakel DebakelOrakel merged commit f7f3f4f into master Nov 8, 2024
13 checks passed
@DebakelOrakel DebakelOrakel deleted the feat/support-oauth branch November 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants