Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI spec to version 1.5 #24

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Update OpenAPI spec to version 1.5 #24

merged 2 commits into from
Aug 6, 2024

Conversation

ahornerr
Copy link
Collaborator

@ahornerr ahornerr commented Aug 6, 2024

Updates to the latest version of the OpenAPI spec.

May include breaking changes

@@ -10,7 +10,7 @@ all: install-tools fetch-spec process-spec generate-client test

process-spec:
openapi-down-convert --input spec/openapi.json --output spec/openapi-3.0.json
sed -i '' 's/"type": "null"/"nullable": true/g' spec/openapi-3.0.json
sed -i 's/"type": "null"/"nullable": true/g' spec/openapi-3.0.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -i '' flag was causing me issues on Linux. Not sure if the Darwin sed is compatible with -i instead of -i '' but I don't have the hardware to test easily.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah FreeBSD Sed is not, I should just install gnused

Copy link
Collaborator

@kbuechl kbuechl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test i setting

@promiseofcake promiseofcake merged commit d4efe12 into main Aug 6, 2024
1 check passed
@promiseofcake promiseofcake deleted the api-spec-1.5 branch August 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants