Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bkerler
Copy link
Contributor

@bkerler bkerler commented Jan 13, 2024

This PR adds a configuration store to remember the past filament and does compare if the temperature is lower than the filament that has been unloaded before, and if, does set the last filament temperature only for loading until purging has finished, thus preventing the nozzle to clog.

Fix is related to issue #3585, #3083 and #1821

@nazar-pc
Copy link

Not sure where to comment, but these tags on GitHub are extremely annoying for those who subscribe to releases via Atom feed. Please consider an alternative approach there. I'm talking about the likes of https://github.com/prusa3d/Prusa-Firmware-Buddy/releases/tag/build%2F6.0.0-BETA%2B7062.PR3681.B4

@danopernis
Copy link
Member

@nazar-pc thanks for bringing that up. The CI settings that got merged to the master branch after 6.0.0 release seems to contain some changes causing builds to fail and CI system to generate those tags. I will try to fix that tommorow.

Meanwhile I manually deleted those tags.

FYI @bkerler

@spooknik
Copy link

spooknik commented Dec 18, 2024

I appreciate the work done on this PR and I just wanted to chime in with my input.

I think it would be better to apply a purge temp offset derived from the difference in filament load temperatures. So if loading PLA (215) after PETG (240) the purge temp would be 230. I explained my line of thinking here.

Basically the formula is:

Previous Filament Temp - Current Filament Temp = Temp Delta 

Temp Delta * 0.6 = Purge Temp Offset

Current Filament Temp + Purge Temp Offset = Filament Purge Temp

@bkerler bkerler force-pushed the temperature_load_fix branch from 79d7079 to d42a2ba Compare December 18, 2024 13:08
@bkerler
Copy link
Contributor Author

bkerler commented Dec 18, 2024

@spooknik I don't think a delta of 0.6 will be good as for some filament types this will clearly be too low. Guess some testing will be needed to find a reasonable factor. But I will consider your recommendation :)

@spooknik
Copy link

@spooknik I don't think a delta of 0.6 will be good as for some filament types this will clearly be too low. Guess some testing will be needed to find a reasonable factor. But I will consider your recommendation :)

Yea I could see a problem going from PC to PLA for example. I guess you can apply an offset multiplier based on the delta. Bigger delta = bigger multiplier.

@bkerler bkerler force-pushed the temperature_load_fix branch 3 times, most recently from 04fbaf4 to c3f7484 Compare December 19, 2024 10:46
@bkerler bkerler force-pushed the temperature_load_fix branch from c3f7484 to 272316f Compare December 19, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants