-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681
base: master
Are you sure you want to change the base?
Conversation
12d0533
to
863d8df
Compare
863d8df
to
7dd8c6c
Compare
7dd8c6c
to
bdc65cb
Compare
Not sure where to comment, but these tags on GitHub are extremely annoying for those who subscribe to releases via Atom feed. Please consider an alternative approach there. I'm talking about the likes of https://github.com/prusa3d/Prusa-Firmware-Buddy/releases/tag/build%2F6.0.0-BETA%2B7062.PR3681.B4 |
I appreciate the work done on this PR and I just wanted to chime in with my input. I think it would be better to apply a purge temp offset derived from the difference in filament load temperatures. So if loading PLA (215) after PETG (240) the purge temp would be 230. I explained my line of thinking here. Basically the formula is:
|
79d7079
to
d42a2ba
Compare
@spooknik I don't think a delta of 0.6 will be good as for some filament types this will clearly be too low. Guess some testing will be needed to find a reasonable factor. But I will consider your recommendation :) |
Yea I could see a problem going from PC to PLA for example. I guess you can apply an offset multiplier based on the delta. Bigger delta = bigger multiplier. |
04fbaf4
to
c3f7484
Compare
…d than filament on load
c3f7484
to
272316f
Compare
This PR adds a configuration store to remember the past filament and does compare if the temperature is lower than the filament that has been unloaded before, and if, does set the last filament temperature only for loading until purging has finished, thus preventing the nozzle to clog.
Fix is related to issue #3585, #3083 and #1821