Add a delay after power panic, so the printer can reach pause state #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-ress
reviewed
Feb 4, 2024
| @@ -358,13 +361,31 @@ def stop_print(self): | |||
| self.data.printing = False | |||
| self.data.paused = False | |||
|
|
|||
| def get_bed_temperture(self, file_path): | |||
There was a problem hiding this comment.
Suggested change
| def get_bed_temperture(self, file_path): | |
| def get_bed_temperature(self, file_path): |
There was a problem hiding this comment.
Thank you for finding this typo. Not really sure if this version is going to make it in, it might happen that firmware will make these variable waits not necessary
ondratu
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.