Correct caddy PHP_VALUE value as it doesn't support \n #575
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested this myself and it works correctly insert github approved |
|
+1 had been diagnosing this issue for hours, this fixed it :3 |
matthewpi
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line breaks in environment variables in caddy fpm configs don't support the \n notation.
This was causing PHP to set
upload_max_filesizeto100M \n post_max_size = 100M.This lead to
upload_max_filesizebeing evaluated to an invalid value that causes file uploads (such as egg imports) to fail due to the size being aboveupload_max_filesize.This PR replaces the \n with an actual newline.
I've confirmed this works in a fresh testing environment.