Skip to content

Commit

Permalink
fix: getChannelMembers status field include (#347)
Browse files Browse the repository at this point in the history
fix: getChannelMembers status field include
  • Loading branch information
mohitpubnub authored Nov 14, 2023
1 parent 291b212 commit 6ea105a
Show file tree
Hide file tree
Showing 11 changed files with 27 additions and 16 deletions.
11 changes: 8 additions & 3 deletions .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
---
changelog:
- date: 2023-11-14
version: v7.4.4
changes:
- type: bug
text: "Fixes issue of getChannelMembers call not returning status field."
- date: 2023-11-08
version: v7.4.3
changes:
Expand Down Expand Up @@ -917,7 +922,7 @@ supported-platforms:
- 'Ubuntu 14.04 and up'
- 'Windows 7 and up'
version: 'Pubnub Javascript for Node'
version: '7.4.3'
version: '7.4.4'
sdks:
- full-name: PubNub Javascript SDK
short-name: Javascript
Expand All @@ -933,7 +938,7 @@ sdks:
- distribution-type: source
distribution-repository: GitHub release
package-name: pubnub.js
location: https://github.com/pubnub/javascript/archive/refs/tags/v7.4.3.zip
location: https://github.com/pubnub/javascript/archive/refs/tags/v7.4.4.zip
requires:
- name: 'agentkeepalive'
min-version: '3.5.2'
Expand Down Expand Up @@ -1604,7 +1609,7 @@ sdks:
- distribution-type: library
distribution-repository: GitHub release
package-name: pubnub.js
location: https://github.com/pubnub/javascript/releases/download/v7.4.3/pubnub.7.4.3.js
location: https://github.com/pubnub/javascript/releases/download/v7.4.4/pubnub.7.4.4.js
requires:
- name: 'agentkeepalive'
min-version: '3.5.2'
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## v7.4.4
November 14 2023

#### Fixed
- Fixes issue of getChannelMembers call not returning status field.

## v7.4.3
November 08 2023

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ Watch [Getting Started with PubNub JS SDK](https://app.dashcam.io/replay/64ee0d2
npm install pubnub
```
* or download one of our builds from our CDN:
* https://cdn.pubnub.com/sdk/javascript/pubnub.7.4.3.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.7.4.3.min.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.7.4.4.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.7.4.4.min.js
2. Configure your keys:
Expand Down
4 changes: 2 additions & 2 deletions dist/web/pubnub.js
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@
return this;
};
default_1.prototype.getVersion = function () {
return '7.4.3';
return '7.4.4';
};
default_1.prototype._addPnsdkSuffix = function (name, suffix) {
this._PNSDKSuffix[name] = suffix;
Expand Down Expand Up @@ -5386,7 +5386,7 @@
prepareParams: function (_modules, params) {
var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m;
var queryParams = {};
queryParams.include = ['uuid.status', 'uuid.type', 'type'];
queryParams.include = ['uuid.status', 'uuid.type', 'status'];
if (params === null || params === void 0 ? void 0 : params.include) {
if ((_a = params.include) === null || _a === void 0 ? void 0 : _a.customFields) {
queryParams.include.push('custom');
Expand Down
2 changes: 1 addition & 1 deletion dist/web/pubnub.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/core/components/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ var default_1 = /** @class */ (function () {
return this;
};
default_1.prototype.getVersion = function () {
return '7.4.3';
return '7.4.4';
};
default_1.prototype._addPnsdkSuffix = function (name, suffix) {
this._PNSDKSuffix[name] = suffix;
Expand Down
2 changes: 1 addition & 1 deletion lib/core/endpoints/objects/member/get.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var endpoint = {
prepareParams: function (_modules, params) {
var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m;
var queryParams = {};
queryParams.include = ['uuid.status', 'uuid.type', 'type'];
queryParams.include = ['uuid.status', 'uuid.type', 'status'];
if (params === null || params === void 0 ? void 0 : params.include) {
if ((_a = params.include) === null || _a === void 0 ? void 0 : _a.customFields) {
queryParams.include.push('custom');
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pubnub",
"version": "7.4.3",
"version": "7.4.4",
"author": "PubNub <[email protected]>",
"description": "Publish & Subscribe Real-time Messaging with PubNub",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ export default class {
}

getVersion() {
return '7.4.3';
return '7.4.4';
}

_addPnsdkSuffix(name, suffix) {
Expand Down
2 changes: 1 addition & 1 deletion src/core/endpoints/objects/member/get.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const endpoint = {

prepareParams: (_modules, params) => {
const queryParams = {};
queryParams.include = ['uuid.status', 'uuid.type', 'type'];
queryParams.include = ['uuid.status', 'uuid.type', 'status'];

if (params?.include) {
if (params.include?.customFields) {
Expand Down

0 comments on commit 6ea105a

Please sign in to comment.