Blacklight 8 Upgrade #351
Draft
Blacklight 8 Upgrade #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anna Headley <[email protected]>
resolves deprecation warning, but doesn't look right yet. Co-authored-by: Eliot Jordan <[email protected]>
eliminates a deprecation warning: render_search_bar is deprecated and will be removed from a future release (Call `render Blacklight::SearchBarComponent.new' instead). (called from _app_views_shared__header_navbar_html_erb___903966786867993672_57000 at lae-blacklight/app/views/shared/_header_navbar.html.erb:27) Co-authored-by: Eliot Jordan <[email protected]>
This appears to have only ever been overridden for style purposes, but the current upstream search form looks nearly identical to ours at this point, actually probably better. The partial itself is no longer used due to new view component.
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Eliot Jordan <[email protected]>
Instead of deprecated helper Co-authored-by: Eliot Jordan <[email protected]>
silence deprecation Co-authored-by: Eliot Jordan <[email protected]>
silence deprecation Co-authored-by: Eliot Jordan <[email protected]>
and change tabs to spaces in a couple files Co-authored-by: Eliot Jordan <[email protected]>
it's closer to how LAE should look but not styled correctly yet. Co-authored-by: Eliot Jordan <[email protected]> Co-authored-by: Trey Pendragon <[email protected]>
Co-authored-by: Anna Headley <[email protected]> Co-authored-by: Trey Pendragon <[email protected]>
It's included in the upstream template layouts/blacklight/base now if you're using Sprockets. Co-authored-by: Anna Headley <[email protected]> Co-authored-by: Eliot Jordan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress.