Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodeSelector, affinity, tolerations in the Helm chart #548

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

v-yarotsky
Copy link
Contributor

Proposed changes

nodeSelector, affinity, and tolerations are currently ignored unless initContainers is set to a non-empty value, due to a misplaced if in the template.
This change fixes the issue.

`nodeSelector`, `affinity`, and `tolerations` are currently ignored
unless `initContainers` is set to a non-empty value, due to a misplaced
`if` in the template.
Copy link

github-actions bot commented Feb 6, 2024

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link

github-actions bot commented Feb 6, 2024

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@mjeffryes mjeffryes requested a review from rquitales February 6, 2024 23:47
@rquitales rquitales self-assigned this Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Member

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. I've also bumped the versions for our charts. @dirien can you do a quick review as well to make sure this flow is correct?

@rquitales rquitales requested a review from dirien February 8, 2024 01:46
Copy link

github-actions bot commented Feb 8, 2024

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@v-yarotsky, nice catch! That was a big L from my side! 😱

@rquitales rquitales merged commit 758a514 into pulumi:master Feb 8, 2024
7 checks passed
@v-yarotsky v-yarotsky deleted the vy-fix-helm-chart-node-selector branch February 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants