-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nodeSelector
, affinity
, tolerations
in the Helm chart
#548
Fix nodeSelector
, affinity
, tolerations
in the Helm chart
#548
Conversation
`nodeSelector`, `affinity`, and `tolerations` are currently ignored unless `initContainers` is set to a non-empty value, due to a misplaced `if` in the template.
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. I've also bumped the versions for our charts. @dirien can you do a quick review as well to make sure this flow is correct?
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@v-yarotsky, nice catch! That was a big L from my side! 😱
Proposed changes
nodeSelector
,affinity
, andtolerations
are currently ignored unlessinitContainers
is set to a non-empty value, due to a misplacedif
in the template.This change fixes the issue.