Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 LVGL 8.3: Fix lcd::print() #30

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Conversation

Richard-Stump
Copy link
Contributor

@Richard-Stump Richard-Stump commented Mar 24, 2023

Overview:

This PR fixes the lcd::print() issue (#25) that was encountered by the beta testers. This fix is for the 8.3.x version of liblvgl, and the same fix has been implemented for 5.3.x at the following PR: #31

Part of this fix necessitated changes in the kernel repo, which can be found in the following PR on the kernel repo: purduesigbots/pros#560

Tests:

  • Make sure everything compiles
  • Test on a brain to ensure that that lcd::print() now works
  • Test on a brain, but from a new project to ensure that it doesn't just work on this repo

image

Copy link
Member

@WillXuCodes WillXuCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has been HW tested as a template and works, this is ready.

@Richard-Stump Richard-Stump merged commit 6bbc352 into develop Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants