Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grace_period, fixed a bug with extra late date and extensions, … #625

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

etrickel
Copy link
Contributor

Added @zardus suggested grace_period and fixed a bug with extensions and extra late date where a submission was not getting counted when it fell in between the two dates after an extension was added.

While working on those items, I also improved the due date messages on the module page. 1) If we are past the first due date but there's an extra late due date then it will show that date. 2) If both dates are passed, it will now display that the due dates have passed instead of just being blank. 3) If the creator has show_penalty set in the course.yml then it will show the current flag values (i.e., the penalty adjusted percentage).

@ConnorNelson
Copy link
Member

I'm going to merge this now.

Going forward, the path to changing how grading works will be #586.

Ultimately, we have multiple instructors trying to use different grading schemes. Continuously increasing complexity in the dojo surrounding different grading paradigms / edge-cases is no good, and should be pretty nicely addressed by something like #586.

@ConnorNelson ConnorNelson merged commit 942bcaa into pwncollege:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants