Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting <text> tags from SVG files #1029

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions fpdf/svg.py
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,8 @@ def handle_defs(self, defs):
self.build_path(child)
elif child.tag in xmlns_lookup("svg", "image"):
self.build_image(child)
elif child.tag in xmlns_lookup("svg", "text"):
self.build_text(child)
elif child.tag in shape_tags:
self.build_shape(child)
elif child.tag in xmlns_lookup("svg", "clipPath"):
Expand Down Expand Up @@ -928,6 +930,8 @@ def build_group(self, group, pdf_group=None):
pdf_group.add_item(self.build_xref(child))
elif child.tag in xmlns_lookup("svg", "image"):
pdf_group.add_item(self.build_image(child))
elif child.tag in xmlns_lookup("svg", "text"):
pdf_group.add_item(self.build_text(child))
else:
LOGGER.debug("Unsupported SVG tag: <%s>", child.tag)

Expand Down Expand Up @@ -968,6 +972,43 @@ def apply_clipping_path(self, stylable, svg_element):
clipping_path_id = re.search(r"url\((\#\w+)\)", clipping_path)
stylable.clipping_path = self.cross_references[clipping_path_id[1]]

@force_nodocument
def build_text(self, text):
if "dx" in text.attrib or "dy" in text.attrib:
raise NotImplementedError(
'"dx" / "dy" defined on <text> is currently not supported (but contributions are welcome!)'
)
if "lengthAdjust" in text.attrib:
raise NotImplementedError(
'"lengthAdjust" defined on <text> is currently not supported (but contributions are welcome!)'
)
if "rotate" in text.attrib:
raise NotImplementedError(
'"rotate" defined on <text> is currently not supported (but contributions are welcome!)'
)
if "style" in text.attrib:
raise NotImplementedError(
'"style" defined on <text> is currently not supported (but contributions are welcome!)'
)
if "textLength" in text.attrib:
raise NotImplementedError(
'"textLength" defined on <text> is currently not supported (but contributions are welcome!)'
)
if "transform" in text.attrib:
raise NotImplementedError(
'"transform" defined on <text> is currently not supported (but contributions are welcome!)'
)
font_family = text.attrib.get("font-family")
font_size = text.attrib.get("font-size")
# TODO: reuse code from line_break & text_region modules.
# We could either:
# 1. handle text regions in this module (svg), with a dedicated SVGText class.
# 2. handle text regions in the drawing module, maybe by defining a PaintedPath.text() method.
# This may be the best approach, as we would benefit from the global transformation performed in SVGObject.transform_to_rect_viewport()
svg_text = None
self.update_xref(text.attrib.get("id"), svg_text)
return svg_text

@force_nodocument
def build_image(self, image):
href = None
Expand Down
Binary file added test/svg/generated_pdf/text-samples.pdf
Binary file not shown.
1 change: 1 addition & 0 deletions test/svg/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,7 @@ def Gs(**kwargs):
svgfile("use-image-def.svg"),
id="Use xlink:href to insert an <image> from <defs>",
),
pytest.param(svgfile("text-samples.svg"), id="<text> tests"),
)

svg_path_edge_cases = (
Expand Down
2 changes: 1 addition & 1 deletion test/svg/svg_sources/embedded-raster-images.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions test/svg/svg_sources/text-samples.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading