Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable 3d for pygfx #15

Merged
merged 12 commits into from
Jun 9, 2024
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jun 9, 2024

there is a remaining bug/issue: after spending some time with it, I still can't get the pygfx orbit camera to rotate around the middle of the volume. will have to tackle it later

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 76.27119% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (95017fa) to head (187dfd3).

Current head 187dfd3 differs from pull request most recent head fb7a174

Please upload reports for the commit fb7a174 to get more accurate results.

Files Patch % Lines
src/ndv/viewer/_backends/_pygfx.py 75.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #15       +/-   ##
===========================================
+ Coverage   70.90%   81.43%   +10.53%     
===========================================
  Files          13       13               
  Lines        1172     1212       +40     
===========================================
+ Hits          831      987      +156     
+ Misses        341      225      -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 enabled auto-merge (squash) June 9, 2024 15:01
@tlambert03 tlambert03 merged commit 01090f2 into pyapp-kit:main Jun 9, 2024
12 checks passed
@tlambert03 tlambert03 deleted the update-pygfx branch June 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant