Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spinner when loading frames #9

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

tlambert03
Copy link
Member

Untitled.mov

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.89%. Comparing base (7b6e48a) to head (1ffd7b5).

Files Patch % Lines
src/ndv/viewer/_components.py 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   69.19%   69.89%   +0.69%     
==========================================
  Files          12       13       +1     
  Lines        1162     1189      +27     
==========================================
+ Hits          804      831      +27     
  Misses        358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 2e2b53f into pyapp-kit:main Jun 9, 2024
14 checks passed
@tlambert03 tlambert03 deleted the spinner branch June 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant