Merge pull request #4763 from pybamm-team/generalize-get-esoh-solver

don't get esoh solver for any non-lithium-ion model
pybamm-team · Jan 17, 2025 · c9cb2bb · c9cb2bb
2 parents 1ac422a + 7342d4e
commit c9cb2bb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/pybamm/simulation.py b/src/pybamm/simulation.py
@@ -1022,8 +1022,8 @@ def step(
     def _get_esoh_solver(self, calc_esoh):
         if (
             calc_esoh is False
-            or isinstance(self._model, pybamm.lead_acid.BaseModel)
-            or isinstance(self._model, pybamm.equivalent_circuit.Thevenin)
+            or not isinstance(self._model, pybamm.lithium_ion.BaseModel)
+            or self._model.options["particle phases"] not in ["1", ("1", "1")]
             or self._model.options["working electrode"] != "both"
         ):
             return None