-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup mypy config #3853
Conversation
fa53c17
to
f62d36a
Compare
Note: when ready, this PR should close #3489, since setting up the type checking configurations was the only remaining task on the list. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3853 +/- ##
=========================================
Coverage 99.60% 99.60%
=========================================
Files 259 259
Lines 21284 21480 +196
=========================================
+ Hits 21200 21396 +196
Misses 84 84 ☔ View full report in Codecov by Sentry. |
2a9612d
to
da42761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Saransh-cpp! Question: should we add the from __future__ import annotations
statement to every file in the source code? We aren't doing it currently, but I do remember that there is a particular tool that does it and lints files for its absence.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Adding the isort rule blowed up this PR. I'll exclude examples from the isort rule. |
in the light of further changes, can review this again when this is ready again
@Saransh-cpp This is pretty old, can we close it since the work would likely have to be redone? |
Hi, yes. There are a ton of conflicts and it would just be better to start this PR from scratch. Thanks for the ping! |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3489
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: