Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr, chore: Enforce deprecations and clean up warnings. #742

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Aug 12, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

This PR cleans up the deprecations introduced previously, and it makes sure no warnings are triggered during the tests.

There is still some Numba code using reflected lists (which are deprecated); that needs to be refactored.

@hameerabbasi hameerabbasi requested a review from mtsokol August 12, 2024 10:16
@hameerabbasi hameerabbasi force-pushed the maint branch 3 times, most recently from ff34098 to 57913dd Compare August 12, 2024 10:34
Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #742 will not alter performance

Comparing hameerabbasi:maint (7325544) with main (847023e)

Summary

βœ… 44 untouched benchmarks

examples/sparse_finch.ipynb Show resolved Hide resolved
sparse/numba_backend/_common.py Outdated Show resolved Hide resolved
sparse/numba_backend/_coo/core.py Show resolved Hide resolved
@hameerabbasi hameerabbasi requested a review from mtsokol August 14, 2024 10:11
@hameerabbasi hameerabbasi merged commit 889ac33 into pydata:main Aug 14, 2024
17 of 19 checks passed
@hameerabbasi hameerabbasi deleted the maint branch August 14, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants