Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eig Rewrites #1126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Eig Rewrites #1126

wants to merge 2 commits into from

Conversation

tanish1729
Copy link
Contributor

@tanish1729 tanish1729 commented Dec 14, 2024

Description

Adds rewrites for eigenvalue eigenvector calculations

  1. For identity matrix, all the eigenvalues are 1 and eigenvectors are standard basis
  2. For diagonal matrix, the eigenvalues are the diagonal elements and the eigenvectors are the standard basis

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1126.org.readthedocs.build/en/1126/

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (231a977) to head (bdd1679).

Files with missing lines Patch % Lines
pytensor/tensor/rewriting/linalg.py 93.93% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   82.10%   82.13%   +0.02%     
==========================================
  Files         185      185              
  Lines       48130    48163      +33     
  Branches     8669     8675       +6     
==========================================
+ Hits        39519    39558      +39     
+ Misses       6444     6439       -5     
+ Partials     2167     2166       -1     
Files with missing lines Coverage Δ
pytensor/tensor/rewriting/linalg.py 92.85% <93.93%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant